Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gitlab revoke option so vault doesn't revoke the token when the parent expires #52

Merged
merged 6 commits into from
Feb 23, 2024

Conversation

ilijamt
Copy link
Owner

@ilijamt ilijamt commented Feb 22, 2024

Allow us to skip the vault revocation process, and let Gitlab revoke the tokens.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 97.64706% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.95%. Comparing base (1825ae7) to head (ce4e8f9).

Files Patch % Lines
secret_access_tokens.go 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   87.88%   87.95%   +0.07%     
==========================================
  Files          15       15              
  Lines         949      955       +6     
==========================================
+ Hits          834      840       +6     
  Misses         68       68              
  Partials       47       47              
Flag Coverage Δ
unittests 87.95% <97.64%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilijamt ilijamt changed the title Add gitlab revoke option feat: add gitlab revoke option so vault doesn't revoke the token when the parent expires Feb 23, 2024
@ilijamt ilijamt merged commit ccf9a51 into main Feb 23, 2024
6 checks passed
@ilijamt ilijamt deleted the add-gitlab-revoke-option branch February 23, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant