Warning on apt-fast.config file while reconfigure apt-fast

[Dab0u1]

Hi,

Dont know if I am in the right place but...
When you run dpkg-reconfigure on apt-fast version 1.8.3137+git7b72bb7-0ubuntu1ppa3 (on willy and xenial) wich is on https://launchpad.net/~saiarcot895 ppa you have this warning at the end of the reconfiguring:
Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/${ <-- HERE _MAXNUM}/ at /var/lib/dpkg/info/apt-fast.config line 205."
The original line is:
if ($downloadcmd =~ /${_MAXNUM}/){
But it can be replaced by
if ($downloadcmd =~ /${_MAXNUM}/){ and the regex warning will disapear.

Edit: I'm sorry but I don't know why but the corrected code don't appear even in the brace, so I put space to see it:
if ($downloadcmd =~ /$ \ <-- HERE {_MAXNUM}/){

[Burnfaker]

hi, can you put it in the code braces?

so here :)

[chrstphrchvz]

I think this has to do with PPA/.deb packaging rather than the code on this repo, @saiarcot895 is who I would refer this to

[bepstein111]

So this has just always been a thing that I ignored while using apt-fast, but after trying to install today on Kubuntu 17.10, it's outright preventing me from using apt-fast at all. Maybe it's more strict about illegal regex? Anyway, while attempting to fix this, I've run into multiple issues:
First, the above "solution" is incorrect. I think it has the solution in the place of the original line:
if ($downloadcmd =~ /\${_MAXNUM}/){
(notice the /\ before ${_MAXNUM/})
and second, upon trying the solution, dpkg complains that _MAXNUM was never declared:
Global symbol "$_MAXNUM" requires explicit package name (did you forget to declare "my $_MAXNUM"?) at /var/lib/dpkg/info/apt-fast.config line 212.
It might not have to do with the code, as @chrstphrchvz said, but if it's going to break the whole app, then it's our problem.

[Lasall]

Thank you for reporting this issue and providing a fix. I updated the apt-fast/stable PPA with the current version and fixed this issue in the config file.