Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting Breaks with jQuery UI 1.13+ #138

Open
FritzTGreen opened this issue Jan 27, 2022 · 4 comments
Open

Sorting Breaks with jQuery UI 1.13+ #138

FritzTGreen opened this issue Jan 27, 2022 · 4 comments

Comments

@FritzTGreen
Copy link

This closed issue in the jQuery UI repository confirms and describes the issue.

Essentially, if using jQuery UI 1.13 or higher, attempting to drag an item in a nested sortable list freezes the list.

This issue does not happen with jQuery UI 1.12.

Is anybody maintaining a fork in which this issue has been resolved?

Thanks!
Fritz

@rubenschulz
Copy link

Hi Fritz,

I had the same issue as you, this seems to be broken in jquery ui, not in this tool.
I managed to fix this by changing 2 lines in the jquery-ui.js file:

On line 16164 and 16165, replace those line:
verticalDirection = this.dragDirection.vertical;
horizontalDirection = this.dragDirection.horizontal;

with:
verticalDirection = this._getDragVerticalDirection();
horizontalDirection = this._getDragHorizontalDirection();

Hope this helps!

@FritzTGreen
Copy link
Author

FritzTGreen commented Feb 9, 2022 via email

@codertushar
Copy link

codertushar commented Oct 28, 2022

This is fixed in 2.1a version of current library:
https://github.com/ilikenwf/nestedSortable/blob/master/jquery.mjs.nestedSortable.js#L266-L269

Changing in jquery-ui as suggested in above comments is not required.

@FritzTGreen Please release it in a new tag as also requested in #141

TomasLudvik added a commit to shopsys/shopsys that referenced this issue Feb 9, 2023
- newer version breaks nestedSortable ilikenwf/nestedSortable#138
- this can be fixed by changing nestedSortable to https://github.com/ilikenwf/nestedSortable after they release newer version than 2.0.0
TomasLudvik added a commit to shopsys/shopsys that referenced this issue Feb 9, 2023
- newer version breaks nestedSortable ilikenwf/nestedSortable#138
- this can be fixed by changing nestedSortable to https://github.com/ilikenwf/nestedSortable after they release newer version than 2.0.0
TomasLudvik added a commit to shopsys/shopsys that referenced this issue Feb 14, 2023
- newer version breaks nestedSortable ilikenwf/nestedSortable#138
- this can be fixed by changing nestedSortable to https://github.com/ilikenwf/nestedSortable after they release newer version than 2.0.0
@ucjonathan
Copy link

@rubenschulz Thank you for posting that fix. Dealing with that exact issue right now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants