Remove attributes bound via xbl:attr if they don't exist on the bound…

… element, per http://www.w3.org/TR/xbl/#how-attribute
ilinsky · Aug 24, 2011 · 8d05154 · 8d05154
1 parent 12e14f7
commit 8d05154
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/source/dom-xbl/ElementXBL.js b/source/dom-xbl/ElementXBL.js
@@ -67,10 +67,16 @@ cElementXBL.prototype.addBinding	= function(sDocumentUri) {
 						if (aNames[1].indexOf(':' + "text") >-1)
 							oElement.setAttribute(aNames[0], this.textContent || this.innerText);
 						else
-							oElement.setAttribute(aNames[0], this.getAttribute(aNames[1]));
+						  if (this.hasAttribute(aNames[1]))
+  							oElement.setAttribute(aNames[0], this.getAttribute(aNames[1]));
+  						else
+  						  oElement.removeAttribute(aNames[0]);
 					}
 					else
-						oElement.setAttribute(aNames[0], this.getAttribute(aNames[0]));
+					  if (this.hasAttribute(aNames[0]))
+  						oElement.setAttribute(aNames[0], this.getAttribute(aNames[0]));
+  					else
+  					  oElement.removeAttribute(aNames[0]);
 				}
 			}
 		}
@@ -309,4 +315,4 @@ function fTemplateElement_getElementById(sId) {
 		}
 		return oElement;
 	})(this.firstChild));
-};
+};