This repository has been archived by the owner on Feb 3, 2024. It is now read-only.
Filter events on the calendar by a vocabulary term #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 281deea |
jrjohnson
force-pushed
the
term-cal-filter
branch
2 times, most recently
from
ab8addc
to
2c86882
Compare
jrjohnson
force-pushed
the
term-cal-filter
branch
from
2c86882
to
9fb0bb2
Compare
|
click-tested for accuracy and functionality. passes. |
stopfstedt
suggested changes
Dec 12, 2017
|
|
||
| let results = a.concat(b, c, d); | ||
| this.set('activeFilters', results); | ||
| const activeFilters = [].concat(a, b, c, d, e); |
There was a problem hiding this comment.
no need to assign this to a variable
const activeFilters = [].concat(a, b, c, d, e);
return activeFilters;
can be shortened to return [].concat(a, b, c, d, e);
stopfstedt
approved these changes
Dec 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ilios/frontend#1636
WIP: