Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT Expiration and Management #1007

Merged
merged 10 commits into from
Sep 8, 2015
Merged

Conversation

jrjohnson
Copy link
Member

Lots of JWT stuff:

  • Added console commands to create and invalidate tokens.
  • Replaced the entire JWT special namespace with a single symphony pre auth class that handles all the validation and creating of tokens
    • Use a JWTManager to do all token operations

Fixes #885, #886, #954

Cleans up a lot of code and is much simpler to understand.
We’re no longer using this header so its OK if symphony leaves it out
Now authentication just creates a response with the JWT string
I think this is a clearer path to what is essentially a token generator
These got out of sync at some point.
Registry::getRepository() requires an active database connection.  By
doing this on demand we make it possible to inject the managers into
console commands.  While the manager obviously needs the DB to be setup
all console commands which are registered as services are setup when
any of them are called.
@stopfstedt
Copy link
Member

logging out application leaves application in a broken state.

selection_009

@jrjohnson
Copy link
Member Author

I think this can be merged as is and then the frontend adjusted to accommodate.

thecoolestguy added a commit that referenced this pull request Sep 8, 2015
@thecoolestguy thecoolestguy merged commit 3f219c9 into ilios:master Sep 8, 2015
@jrjohnson jrjohnson deleted the 886-expirejwt branch November 10, 2015 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants