Fix issue with production install #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fail when the AppKernel and composer.json file list differing production / development dependencies.
It was already moved to production area of AppKernel when we started adding installation fixtures.
APC is a requirement of our application in production.
Since we’re attempting a production composer install it also attempts to access mysql sooner so we need the parameters.yml.travis file installed.
This is needed by composer install in a production environment
thecoolestguy
added a commit
that referenced
this pull request
Sep 13, 2015
Fix issue with production install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctrine-fixtures-bundle was incorrectly in the require-dev section of our composer file. This prevents it from being installed in a production environment and causes any production install to fail. I fixed this issue and also modified our travis build to prevent it happening again.