Handle deleted offerings in the user API #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
| return $this->instructorIlmSessions; | ||
|
|
||
| //criteria not 100% reliable on many to many relationships | ||
| //fix in https://github.com/doctrine/doctrine2/pull/1399 |
|
@dartajax, please merge! |
dartajax
added a commit
that referenced
this pull request
Sep 25, 2015
Handle deleted offerings in the user API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix is that user instructedOfferings and instructedIlmSessions no longer return deleted offerings or sessions.
I also added
InvalidInputWithSafeUserMessageExceptionwhich when thrown results in a 400 error and the display of the exception message to the API user.