-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change alerts command. #1038
change alerts command. #1038
Conversation
|
$subject = $offering->getSession()->getCourse()->getExternalId() . ' - ' | ||
. $offering->getStartDate()->format('m/d/Y'); | ||
|
||
$school = $offering->getSession()->getCourse()->getSchool(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the template should be driven by the alert recipients as opposed to the primary school of the course. I'm probably wrong though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are correct. good catch. fixing it...
@jrjohnson can be reviewed again. |
👍 |
@homu r+ |
📌 Commit 640f11a has been approved by |
change alerts command. ``` vagrant@ilios:/vagrant$ bin/console ilios:messaging:send-change-alerts --help Usage: ilios:messaging:send-change-alerts [options] Options: --dry-run Print out alerts instead of emailing them. Useful for testing/debugging purposes. -h, --help Display this help message -q, --quiet Do not output any message -V, --version Display this application version --ansi Force ANSI output --no-ansi Disable ANSI output -n, --no-interaction Do not ask any interactive question -s, --shell Launch the shell. --process-isolation Launch commands from shell as a separate process. -e, --env=ENV The Environment name. [default: "dev"] --no-debug Switches off debug mode. -v|vv|vvv, --verbose Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug Help: Sends out change alert message to configured email recipients. ``` fixes #992.
☀️ Test successful - status |
fixes #992.