Fixes for program, user and learningmaterial endpoints #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the difficult to understand instructedUserGroups with instructedLearnerGroups on the users endpoint Remove the deprecated instructors column from the group table Replace instructorUsers with instructors on the learner groups endpoint.
ProgramYearSteward was missing from these APIs and is needed.
| @@ -225,19 +225,19 @@ public function testSetLearnerGroups() | |||
| } | |||
|
|
|||
| /** | |||
| * @covers Ilios\CoreBundle\Entity\User::addInstructorUserGroup | |||
| * @covers Ilios\CoreBundle\Entity\User::addInstructedLearnerGroups | |||
There was a problem hiding this comment.
should be
@covers Ilios\CoreBundle\Entity\User::addInstructedLearnerGroup
|
@ctam - take note of this change please. We're modifying the API for the way you would list the instructors fora learner group. |
|
I'm going to add the changes from #1040 to this as well |
jrjohnson
changed the title
In order to get a path we need access to the symphony router which is not available in the learning material entity. So the controller has to instead use a factory to decorate each entity as it is returned and processed. The allows the factory to be a service which receives the Router as a dependancy. Also removed token and relativePath from the learning material API as these are internal implementation items and not needed for public consumption.
|
LGTM 👍 |
dartajax
added a commit
that referenced
this pull request
Oct 6, 2015
Fixes for program, user and learningmaterial endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProgramYearSteward was missing from school, department, and program year APIs and is needed.
Modify api relationship between users and learner groups Replace the difficult to understand instructedUserGroups with
instructedLearnerGroups on the users endpoint
Remove the deprecated instructors column from the group table
Replace instructorUsers with instructors on the learner groups endpoint.
In order to get a path we need access to the symphony router which is not available in the learning material entity. So the controller has to instead use a factory to decorate each entity as it is returned and processed. The allows the factory to be a service which receives the Router as a dependancy.
Also removed token and relativePath from the learning material API as these are internal implementation items and not needed for public consumption.
Fixes #1040