Don't allow saving of the many side on a one to many relationship #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember data doesn’t send this data, and symphony won’t update from this side, so we shouldn’t allow the form field at all.
Ensure that entities __construct method sets up necessary empty properties on creation Test to ensure that these are set in the entity unit tests Don't submit the many side of a one to many relationship in controller tests
These don't persist well due to the manyToMany and the string based key.
jrjohnson
force-pushed
the
one-to-many-api
branch
from
e89bdd0
to
497018b
Compare
|
👍 @homu +r |
|
@homu r=stopfstedt |
|
📌 Commit 497018b has been approved by |
homu
added a commit
that referenced
this pull request
Oct 23, 2015
Don't allow saving of the many side on a one to many relationship - Ember data doesn’t send this data, and symphony won’t update from this side, so we shouldn’t allow the form field at all. - Ensure that entities __construct method sets up necessary empty properties on creation. - Test to ensure that these are set in the entity unit tests - Don't submit the many side of a one to many relationship in controller tests Fixes #1059
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1059