Add new taxonomy system #1279
Merged
Add new taxonomy system #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saschaben please review ERD:
|
|
looks good. please validate independently as well against https://ucsf.box.com/s/9yp0j1xait48n5gqlylvomxtbqextri7 |
|
per our conversation:
|
This was referenced Jan 27, 2016
| * @JMS\ExclusionPolicy("all") | ||
| * @JMS\AccessType("public_method") | ||
| */ | ||
| class Vocabulary implements VocabularyInterface |
There was a problem hiding this comment.
Can't this be a CatagorizableEntity?
There was a problem hiding this comment.
it totally can! good catch.
|
@stopfstedt couple of questions - none of them are breaking. |
… assoc as deprecated.
|
@jrjohnson fixed all outstanding issues, please review/merge. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1257.
this adds the new
vocabularyandtermtables, as well as join tables toschool,session,courseandprogram_year.this does not remove the legacy
topictable and associated code from the system just yet, new and old taxonomy systems will exist in parallel.data migration from topics to vocab/terms are out of scope as well and need to be addressed in a separate issue.