Remove support for PHP 5.4 #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5.6 is the only supported version in the 5.x series, but 5,5 is still the default on OS X. While 5.5 is supported and tested 5.6 is the preferred version.
The latest minor release of all of our dependancies.
New PHPCS version found additional errors in existing code.
|
I'm sticking a DO NOT MERGE on this because we probably want to wait until after we tag 3.4 and then merge this. |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.6 is the only supported version in the 5.x series, but 5,5 is still
the default on OS X. While 5.5 is supported and tested 5.6 is the
preferred version.
Also updated all of our composer dependancies to their most recent minor version.
Fixes #1302