disable profiler in test env. #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,7 @@ monolog: | |||
|
|
|||
| liip_functional_test: | |||
| cache_sqlite_db: true | |||
| query_count.max_query_count: 50 | |||
| #query_count.max_query_count: 50 | |||
There was a problem hiding this comment.
Lets just toss this - we're not hitting it now - and its about as bad as it can get for query count. I say just take out this whole section.
jrjohnson
added a commit
that referenced
this pull request
Feb 12, 2016
disable profiler in test env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i yanked the Liip profiler and query counter in all environments, and only enabled the profiler in test env.
based on this recommendation: http://symfony.com/doc/current/cookbook/testing/profiling.html#speeding-up-tests-by-not-collecting-profiler-data
we were getting warnings in travis:
see: https://github.com/liip/LiipFunctionalTestBundle#query-counter