added aamc resource type and rigged it up to terms. #1399
Conversation
|
requires the following command to be run as part of the update process of existing instances: this will import the AAMC resource types. |
|
Code reviewed looks good. Maybe we should add the update command to the UPGRADE.md file as part of the PR? - lets discuss how to integrate these types of update notes in our meeting on Monday. |
| @@ -293,7 +306,7 @@ protected function attachCriteriaToQueryBuilder(QueryBuilder $qb, $criteria, $or | |||
|
|
|||
| if (is_array($orderBy)) { | |||
| foreach ($orderBy as $sort => $order) { | |||
| $qb->addOrderBy('t.' . $sort, $order); | |||
| $qb->addOrderBy('t.'.$sort, $order); | |||
There was a problem hiding this comment.
idk, that should not be. reverting this change.
|
As discussed in our meeting please add upgrade instructions to UPGRADE.md at the top of the file. |
|
@jrjohnson, please review updated upgrade instructions. thank you. |
|
I'm now wondering if we should indicate that a migration needs to be run each time. I really have no idea how to make this obvious and easy to use. @thecoolestguy any thoughts? |
|
how about this - add a "general upgrade notes" section to the top of this file, outlining the following steps that are assumed to be run each time:
maybe? |
|
Yea - that makes sense. That is at the top. Then each version specific step (if required) is at the bottom. i like. |
|
additional schema changes may, or may not, happen here. soon. i'm putting this back on hold. |
|
☔ The latest upstream changes (presumably #1421) made this pull request unmergeable. Please resolve the merge conflicts. |
|
ready for review again. |
| @@ -36,7 +36,17 @@ sudo -u apache bin/console cache:clear --env=prod | |||
|
|
|||
| ## Version-specific steps | |||
|
|
|||
| _to be done_ | |||
| ### Upgrading to Ilios 3.11.0 | |||
There was a problem hiding this comment.
Should be 3.12.0 which is the next version.
|
Tiny tweak to version in README and then this is ready to merge. |
fixes #566