course rollover command #1469
Merged
course rollover command #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion and offering models
…vs. disciplines -- and successfully used for redmine #6142
…, as well as same year but weeks earlier or later
|
something else - 'topics' are an outmoded concept. replace with 'terms' everywhere. |
Testing the basics now, now relationships really and no sessions.
Same thing, little bit more idiomatic.
Course and session objectives need to be cloned otherwise changes in the future can modify courses that are already locked.
Ensure that we're creating new objectives not linked ones. Also checks to see that the parents are sort of the same by comparing the count.
Limiting calls to once revealed test errors and a double call to course setMeshDescriptors
gmp_sign is part of a non-bundled set of dependencies which are difficult to install on OSX.
This is not a required relationship so we need to ensure it is present before attempting to roll it over.
|
|
||
| //taken with gratitude from http://php.net/manual/en/function.gmp-sign.php#106246 | ||
| $weeksOffsetModifier = ( $weeksOffset > 0 ) ? 1 : ( ( $weeksOffset < 0 ) ? -1 : 0 ); | ||
| $offsetInWeeks = (($weeksOffsetModifier < 0) ? '-' : '+') . ' ' . abs($weeksOffset) . ' weeks'; |
There was a problem hiding this comment.
is it possible to end up with a 0 value for $weekOffsetModifier? if so, then the code should check for that and skip the start/end-date modification below.
…ected @return value annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1286
Todo: