More rollover tests #1486
Merged
More rollover tests #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look for and handle the strings 'false' and 'true' when dealing with course rollover options
Currently skipped, but test the service to ensure that the startDate is set correctly for courses in the future.
When setting the start date courses should rollover to that date
Courses in the same year require a custom start date and must move offerings that far forward.
In this case the existing course cohorts, course objective parents, and offering learner groups should be maintained.
Courses rolled over into the same year should not have offering learner and learner group relationships maintained.
|
@thecoolestguy if it would be easier we can merge these tests first which you can re-enable and use in your own work on #1478 |
|
After discussion with @thecoolestguy this should be merged now with skipped tests. These tests can then be used to ensure his work is complete. @stopfstedt ready for review. |
|
i accept this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for courses with specific start dates and start dates in the future. Many of these tests are skipped now while @thecoolestguy makes some changes to the service.
Changes to service are mergedSkipped tests added here are enabledFixes #1483
Fixes #1485