Don't set the session if we are unsetting the ILM session #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ILM is removed from a session we send NULL to this method. We should not then turn around and attempt to set the session on that NULL values.
jrjohnson
force-pushed
the
1564-setilmsession
branch
from
cbb9142
to
4ca7e79
Compare
|
@homu r+ |
|
📌 Commit 4ca7e79 has been approved by |
homu
added a commit
that referenced
this pull request
Sep 7, 2016
Don't set the session if we are unsetting the ILM session When ILM is removed from a session we send NULL to this method. We should not then turn around and attempt to set the session on that NULL values. Fixes #1564
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ILM is removed from a session we send NULL to this method. We
should not then turn around and attempt to set the session on that NULL
values.
Fixes #1564