Fix Learning Material absolute path #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
1574-lmurl
branch
from
b7076b4
to
32663eb
Compare
Symfony 3 introduced a new way of getting the absolute path. Required messing with some test data to get a good test to run
jrjohnson
force-pushed
the
1574-lmurl
branch
from
32663eb
to
1a16be8
Compare
|
@homu r+ |
|
📌 Commit 1a16be8 has been approved by |
homu
added a commit
that referenced
this pull request
Sep 9, 2016
Fix Learning Material absolute path Symfony 3 introduced a new way of getting the absolute path. WIP: - [x] Fix tests that I broke messing with test fixture data. Fixes #1574
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 3 introduced a new way of getting the absolute path.
WIP:
Fixes #1574