Enforce permission for archivable and lockable entities #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
1576-access
branch
2 times, most recently
from
9a7fdfb
to
7bed789
Compare
We were using a 'modify' keyword as well as doing voter lookup by allowing a single yes voter to grant permissions. Instead we need to check with all voters.s Also prevent rolling over courses if the user does not have permission
jrjohnson
force-pushed
the
1576-access
branch
from
7bed789
to
03d70a8
Compare
|
@homu r+ |
|
📌 Commit 03d70a8 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Sep 9, 2016
Enforce permission for archivable and lockable entities We were using a 'modify' keyword as well as doing voter lookup by allowing a single yes voter to grant permissions. Instead we need to check with all voters and ensure we are looking for both 'delete' and 'modify' permissions. Fixes #1576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a 'modify' keyword as well as doing voter lookup by
allowing a single yes voter to grant permissions. Instead we need to
check with all voters and ensure we are looking for both 'delete' and
'modify' permissions.
Fixes #1576