Replace Vagrant with docker #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added very basic documentation. @stopfstedt when you get a chance please test this setup on your linux machine. You need docker-compose and then running |
|
☔ The latest upstream changes (presumably ed70bc0) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@jrjohnson this will need a rebase against master, thanks! |
jrjohnson
force-pushed
the
docker-switch
branch
from
d514dd1
to
e7804b6
Compare
jrjohnson
force-pushed
the
docker-switch
branch
from
e7804b6
to
46340c6
Compare
jrjohnson
force-pushed
the
docker-switch
branch
from
46340c6
to
2d62929
Compare
Better volume mapping, connected to demo db, chown necessary symfony write directories.
Hopefully fixes issues on windows systems which do not seems to respect the executable permission on the original file.
Passing true to these new environmental variables will put docker container into development mode.
jrjohnson
force-pushed
the
docker-switch
branch
from
46bd789
to
5051c56
Compare
Just puts the PHP source into an image that can be versioned easily along with the source.
Better sharing of logs and an nginx container that is simplified by removing the entrypoint chown stuff which is now done elsewhere.
These need to be setup so PHP can write here and php-fpm runs as nobody.
stopfstedt
approved these changes
Feb 3, 2017
This was referenced Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our vagrant instance is old and the promise of deploying a vagrant environment to production has never materialized. Instead lets use docker-compose to do this.
Fixes #789, #790, #899
WIP needs: