curriculum inventory report rollover. #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollover testing purposes.
|
rollover component gets thoroughly tested thru the corresponding controller acceptance test. |
jrjohnson
requested changes
Oct 13, 2016
|
|
||
| // generate token after the fact and persist report once more. | ||
| $newReport->generateToken(); | ||
| $this->reportManager->update($newReport, true, true); |
There was a problem hiding this comment.
No need to call this twice the entity should already be persisted from line 92
There was a problem hiding this comment.
token generation needs to happen after initial save. then the record must be saved again. this second save is legit.
jrjohnson
approved these changes
Oct 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1614.