added "root" attribute to user entity #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably dc70e8b) made this pull request unmergeable. Please resolve the merge conflicts. |
stopfstedt
changed the title
jrjohnson
requested changes
Oct 14, 2016
| @@ -470,6 +470,7 @@ public function removeLearnerIlmSession(IlmSessionInterface $learnerIlmSession); | |||
| public function getLearnerIlmSessions(); | |||
|
|
|||
| /** | |||
| <<<<<<< 198377f486608690bd5286f036e4f848848c8c58 | |||
jrjohnson
approved these changes
Oct 14, 2016
|
According to @stopfstedt this needs to have protection in the controller to prevent anyone from setting the root attr for users. |
|
@jrjohnson please re-review, esp. the changes to the |
jrjohnson
reviewed
Oct 19, 2016
| /** | ||
| * @var string | ||
| */ | ||
| const COMMAND_NAME = 'ilios:maintenance:set-root-user'; |
There was a problem hiding this comment.
set-root-user implies to me that there is only one. should probably be called add-root-user.
| /** | ||
| * @var string | ||
| */ | ||
| const COMMAND_NAME = 'ilios:maintenance:unset-root-user'; |
There was a problem hiding this comment.
remove-root-user would make more sense otherwise maybe it removes everyone?
|
@stopfstedt failing test here. |
|
ugh, searched/replaced without thinking. fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1623