Add endpoint to get all materials for a user #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
1635-userlms
branch
3 times, most recently
from
becba2e
to
141aa6b
Compare
jrjohnson
changed the title
|
Tests are blocked on #1646 |
/usermaterials/${id} returns a list of all the learning materials a user
is connected to as a learner.
This is likely to be volatile for a while until we figure out exactly what belongs here.
Calculates the first offering for a materials based on the students association via IlmSession or Offering.
jrjohnson
force-pushed
the
1635-userlms
branch
from
2051a2d
to
5e74799
Compare
Data fixtures were modified for testing usermaterials endpoint and these tests needed some touchups.
jrjohnson
force-pushed
the
1635-userlms
branch
from
5e74799
to
326afec
Compare
|
@jrjohnson i don't see anything in the repo query function that pertains to checking the owning session/course for publication status. not sure if this an issue or not, but it may be. thoughts? |
|
@stopfstedt good catch. |
LMs connected to items in draft or scheduled state should not be displayed for learners attached to those courses / sessions.
|
@stopfstedt ready for review again. |
stopfstedt
approved these changes
Oct 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usermaterials/${id} returns a list of all the learning materials a user
is connected to as a learner.
Fixes #1635