Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Symfony builtin to detect maximum file upload size #1654

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Use Symfony builtin to detect maximum file upload size #1654

merged 1 commit into from
Oct 25, 2016

Conversation

jrjohnson
Copy link
Member

Instead of calculating this on our own just use the static method built
into the Symfony UploadFile class.

@jrjohnson
Use Symfony builtin to detect maximum file upload size
1d65d93 
Instead of calculating this on our own just use the static method built
into the Symfony UploadFile class.
stopfstedt
stopfstedt approved these changes Oct 25, 2016
View reviewed changes
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's way too simple and elegant. REJECTED.

@stopfstedt stopfstedt merged commit 0e13c6c into ilios:master Oct 25, 2016
@jrjohnson jrjohnson deleted the builtin-filesize branch October 25, 2016 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stopfstedt stopfstedt stopfstedt approved these changes

Assignees

@stopfstedt stopfstedt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrjohnson @stopfstedt