Timestamp updated entities outside of the normal flow #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
1683-deadlock
branch
from
1de93a3
to
c5844b1
Compare
|
Comment from @stopfstedt: that we log the deadlocks when we hit them. |
|
Turns out to be unnecessary - I removed the deadlock checking as it was no longer being hit even under heavy load. Regular exceptions will be thrown and logged if we continue to hit this issue. |
By moving the timestamping of entities changed and their related changed sessions and offerings into its own post flush process we will hopefully avoid deadlocks which have frequently occurred here. I had to use the query builder instead of just calling stampUpdate on the entities because when a relationship is deleted in the flush (like sessionDescription) it still attempts to save it in our postFlush event. This causes issues so instead I'm only working with the IDs and not the entities.
jrjohnson
force-pushed
the
1683-deadlock
branch
from
c5844b1
to
a3c23c3
Compare
stopfstedt
approved these changes
Dec 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the timestamping of entities changed and their related changed
sessions and offerings into its own post flush process we will hopefully
avoid deadlocks which have frequently occurred here. I had to use the
query builder instead of just calling stampUpdate on the entities
because when a relationship is deleted in the flush (like
sessionDescription) it still attempts to save it in our postFlush event.
This causes issues so instead I'm only working with the IDs and not the
entities.
Fixes #1683