Log relationship changes for entities #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not capturing what relationships changed for entities because doctrine doesn't include this information. Instead we have to capture what collections were updated and then connect that to a change. This is not as specific as we would like to be, for example if a director is added to a course the log will just say 'Ref:User' it will not indicate if an administrator or director was added or deleted. However baring changes to doctrine this is as good as we can ask for at this point. I also refactored the logger flow a bit to need less code.
jrjohnson
force-pushed
the
1694-auditdata
branch
from
d524066
to
8e9a97c
Compare
stopfstedt
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not capturing what relationships changed for entities because
doctrine doesn't include this information. Instead we have to capture
what collections were updated and then connect that to a change. This
is not as specific as we would like to be, for example if a director is
added to a course the log will just say 'Ref:User' it will not indicate
if an administrator or director was added or deleted. However baring
changes to doctrine this is as good as we can ask for at this point.
I also refactored the logger flow a bit to need less code.
Fixes #1694