Use variable date from offering fixture in tests #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the offerings now uses a variable date in order to stay current. Instead of looking for a static date we need to grab the correct entity and check that date.
New dynamic second offering requires reordering of the offering timestamp expected in these tests.
jrjohnson
force-pushed
the
1716-offeringtests
branch
from
be2dcd3
to
6a662b5
Compare
There are some sorting differences between PHP v5 and v7 that don't make much difference to our application, but do matter for tests. In order to ensure we get consistent test results I added a sort by endDate as well as startDate to the event sorting.
jrjohnson
force-pushed
the
1716-offeringtests
branch
from
84badc2
to
a0f3a03
Compare
stopfstedt
approved these changes
Jan 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the offerings now uses a variable date in order to stay current.
Instead of looking for a static date we need to grab the correct entity
and check that date.
Fixes #1716