Fail gracefully on missing frontend #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
1626-nofrontend
branch
from
a5f1573
to
9f530d4
Compare
Instead of just dying we can be much better with this. By messaging the user during cache:clear and then presenting an error page we can ensure that tests will run even if there is an API mismatch between Ilios and the fronted and no comparable fronted is yet available.
thecoolestguy
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just dying we can be much better with this. By messaging the
user during cache:clear and then presenting an error page we can ensure
that tests will run even if there is an API mismatch between Ilios and
the fronted and no comparable fronted is yet available.
Fixes #1626
The user will see this screen if they attempt to load ilios while there is no frontend: