Prevent users from editing their own account #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this check it is possible for a user to add roles to their own account. This happens because doctrine keeps the User object in sync between our authentication token and the user we modify in the controller. Since our process is to modify users and then check authentication anyone can send a set of roles they want and the roles will be applied before the authorization is checked.
stopfstedt
approved these changes
Feb 27, 2017
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this check it is possible for a user to add roles to their own
account. This happens because doctrine keeps the User object in sync
between our authentication token and the user we modify in the
controller. Since our process is to modify users and then check
authentication anyone can send a set of roles they want and the roles
will be applied before the authorization is checked.
Fixes #1762