prepare to upgrade to PHPUnit 10. #5093
Conversation
stopfstedt
force-pushed
the
phpunit-10
branch
from
8e66103
to
ed99710
Compare
stopfstedt
force-pushed
the
phpunit-10
branch
3 times, most recently
from
67f1dd8
to
d909d2e
Compare
stopfstedt
force-pushed
the
phpunit-10
branch
3 times, most recently
from
b9c68b5
to
3eba810
Compare
| public function graphQLFiltersToTest(): array | ||
|
|
||
| /** | ||
| * @inheritdoc |
There was a problem hiding this comment.
I could do without these since we don't actually use any PHP doc parsing.
There was a problem hiding this comment.
fair. i yanked all of these from the endpoint tests.
✅
| * Class JsonControllerTest | ||
| */ | ||
| trait JsonControllerTest | ||
| trait JsonControllerTestable |
There was a problem hiding this comment.
Maybe being weird, but I don't love this name... maybe TestableJsonController?
| @@ -185,16 +185,16 @@ public function testCreateJwtFromServiceTokenUser() | |||
| $this->assertEquals($this->obj->getExpiresAtFromToken($jwt)->getTimestamp(), $expiresAt->getTimestamp()); | |||
| } | |||
|
|
|||
| public function getWriteableSchoolIdsFromTokenProvider(): array | |||
| public static function getWriteableSchoolIdsFromTokenProvider(): array | |||
There was a problem hiding this comment.
I didn't catch why this is static now, is it used in the providers?
There was a problem hiding this comment.
yes, that method is a data provider. they must to be static and public in PHPUnit v10.
| @@ -17,22 +17,7 @@ public function setUp(): void | |||
| $this->voter = new Voter(); | |||
| } | |||
|
|
|||
| public function supportsTypeProvider(): array | |||
There was a problem hiding this comment.
Am I understanding correctly that this went away because it's only used in GreenLightViewDTOVoter and ReadonOnlyDTOVoter so isn't inherited elsewhere?
There was a problem hiding this comment.
this had to be re-tooled, unfortunately. since the previous method was invoking an abstract method (another data provider), which isn't allowed with abstract static methods.
so i had to push this down into the concrete test classes.
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 9.6.15 to 10.5.1. - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/10.5.1/ChangeLog-10.5.md) - [Commits](sebastianbergmann/phpunit@9.6.15...10.5.1) --- updated-dependencies: - dependency-name: phpunit/phpunit dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…be public and static.
fill these up with actual test vectors.
- replaces <coverage> with <source> - fail on deprecation instead of converting them to exceptions - rm Symfony Bridge listener without replacement since the listener subsystem has been removed without replacement - rm Symfony bridge related env vars
i missed this one during previous passes over this.
the old name was confusing PHPUnit, resulting in a test runner warning.
this has become necessary to prevent these tests from failing.
the symfony bridge isn't ready for v10, let's keep all the code that addresses deprecations/breaking changes with v10 and revert back to v9.
we're not generating docs from test coverage, so this is kinda pointless. removed as requested.
stopfstedt
force-pushed
the
phpunit-10
branch
from
3a74c64
to
6519ce4
Compare
PHPUnit v10 is still a no-go, b/c the PHPUnit/Symfony bridge isn't ready for it yet.
we can still frontload the upgrade by addressing all deprecations that would result in breakage: