Use docker tools for git context on containers #5108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build-push-action from docker manages git for us, in most cases this has been fine. However, for our nightly re-builds we've been pulling off of HEAD instead of the tag we expect. I've removed the checkout from most places so it's clearer what is happening and setup the nightly re-build to use the local git context and not re-checkout the code before building.
thecoolestguy
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build-push-action from docker manages git for us, in most cases this has been fine. However, for our nightly re-builds we've been pulling off of HEAD instead of the tag we expect. I've removed the checkout from most places so it's clearer what is happening and setup the nightly re-build to use the local git context and not re-checkout the code before building.
Fixes #5107