Add configurable preferred names in ldap sync #5442
Conversation
This allows a campus to compute a first name from either a primary directory attribute or, if it is set, a preferred name field. When users are synced their lived or preferred name will be stored in the existing first and last name fields in the database.
jrjohnson
force-pushed
the
configurable-ldap-preffered-names
branch
from
a38a23e
to
9028853
Compare
| @@ -71,7 +71,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| 'Display Name', | |||
| 'Pronouns', | |||
| 'Email', | |||
| 'Phone Number' | |||
| 'Phone Number', | |||
There was a problem hiding this comment.
Is adding a trailing comma just a PHP style thing that is the convention now?
There was a problem hiding this comment.
We haven't done lint enforcement yet so it's not convention today. I was messing with this array and added the trailing comma, I left it in because I like how always having a last item comma makes git diffs easier to read because it doesn't indicate that the comma is a change to the line.
There was a problem hiding this comment.
My experience with PHP testing is limited, so I'm not sure how best to "review" these. If they pass, I'm good!
There was a problem hiding this comment.
In this case tests cover it fairly well. I'd look out for some classic Jon errors like misspelling preferred somewhere, but otherwise we'll test this PR in a staging environment as well before merging to ensure the ldap stuff works agains the UCSF directory.
|
PR deployed to docker for all containers, you can access with the tag |
This allows a campus to compute a first name from either a primary directory attribute or, if it is set, a preferred name field. When users are synced their lived or preferred name will be stored in the existing first and last name fields in the database.