Improvement to container build jobs #5536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jrjohnson
commented
Jun 15, 2024
•
jrjohnson
commented
- Disabled fast failing to containers will build even if one fails
- Added slack messaging when there is a failure
- Use the new GitHub API for passing outputs between jobs
- Updated nginx
- Changed our health check
- Used some new options to change the way we download and run the containers
- Disabled fast failing to containers will build even if one fails - Added slack messaging when there is a failure - Use the new GitHub API for passing outputs between jobs
Always try and start every container, even if the one before failed and output the docker process list every time so we can see what might be failing in a test.
Not sure why, but this startup has slowed down.
localhost stopped working, I'm not 100% clear on why.
This has fallen way behind, the good news is that nginx now provides a "stable-alpine" image so we don't have to remember to update the version in the future.
We have some failures here and I'm not sure why. Playing around with downloading less and putting them in a different place.
jrjohnson
force-pushed
the
improved-container-builds
branch
from
f74dc18
to
ad41040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.