Validate new Learners and Instructors #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a new user from the learner groups or instructors tab now validates input for required fields, email address validity, and campus id min/max length.
This was left around, but now that we are validating it needs to go.
|
@saschaben @dartajax I put a list of the error messages in this pull request. Can you make sure to give them a look and see if you would rather say something else. Once they are all checked off the a developer can take a look and merge. |
|
Should there also be a test to see if the same Campus ID is used more than once in the file raising an error like "Campus ID in the file more than once"? Those errors look good to me otherwise. |
|
AOK. No errMsg for duplicate campus IDs, as temporary IDs may be issued and may be non-unique in some cases. move it along! |
|
That makes sense. |
thecoolestguy
added a commit
that referenced
this pull request
Aug 7, 2014
Validate new Learners and Instructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating single entries on the Instructor and Learner tabs - with tests
Validating CSV uploads and displaying errors by line for these tabs - no tests, couldn't get the file upload to work correctly.
Need to confirm that these messages are correct:
Fixes #561