-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flag Former Students in the sync process #697
Conversation
// process any remaining student records in Ilios | ||
// that did not get flagged as examined. | ||
$disabledStudentsCount = $this->_processUnexaminedStudents($processId, $logger); | ||
|
||
// ---------------------------------- | ||
// 3. Post-run Processing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Step 2' no longer exists, so this should probably be '2. Post-run Processing' OR the initialization step of the process should be 1, and the rest re-ordered...
Testing steps ... from the notes on the white board. This could use additional clarification. I hope this makes at least some sense. This is to be performed in ilios-stage environment.
updated to fix sql to run to enable users. |
Once a student has graduated they tend to have strange entries in the directory. This adds a place for an LDAP query which will only return former students and they can then be flagged that way so some mis-match statuses will be ignored. Students are never unfledged from this automatically, this has to be done in the management console UI where they can also be flagged manually.
Re-ordered the steps to match what is now happening.
Fix a refactoring mistake that was setting all former students to students when they were updated.
Flag Former Students in the sync process
Once a student has graduated they tend to have strange entries in the
directory. This adds a place for an LDAP query which will only return
former students and they can then be flagged that way so some mis-match
statuses will be ignored.
Students are never unfledged from this automatically, this has to be
done in the management console UI where they can also be flagged
manually.
Fixes #327