Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag Former Students in the sync process #697

Merged
merged 5 commits into from
Oct 10, 2014

Conversation

jrjohnson
Copy link
Member

Once a student has graduated they tend to have strange entries in the
directory. This adds a place for an LDAP query which will only return
former students and they can then be flagged that way so some mis-match
statuses will be ignored.
Students are never unfledged from this automatically, this has to be
done in the management console UI where they can also be flagged
manually.

Fixes #327

// process any remaining student records in Ilios
// that did not get flagged as examined.
$disabledStudentsCount = $this->_processUnexaminedStudents($processId, $logger);

// ----------------------------------
// 3. Post-run Processing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Step 2' no longer exists, so this should probably be '2. Post-run Processing' OR the initialization step of the process should be 1, and the rest re-ordered...

@dartajax
Copy link
Member

dartajax commented Oct 8, 2014

Testing steps ... from the notes on the white board. This could use additional clarification. I hope this makes at least some sense.

This is to be performed in ilios-stage environment.

  • Refresh data
  • Update Users by setting enabled = 1 and user_sync_ignore = 0 for 2012 Cohort (or other Cohort currently disabled)
  • Run cron job (Old Code version)
  • Verify these users appear in the Admin Console as exceptions
  • Run cron job (New Code version)
  • Verify these users do NOT appear in the Admin Console as exceptions
  • Change a bunch of email addresses
  • Run cron job (New Code version)
  • Check the Admin Panel >> Exceptions list for these records
  • Change other user attribute (name, MI, UC ID)
  • Run cron job (New Code version)
  • Verify these users do NOT appear in the Admin Console as exceptions and that the Information got updated with the new data.

updated to fix sql to run to enable users.

Once a student has graduated they tend to have strange entries in the
directory.  This adds a place for an LDAP query which will only return
former students and they can then be flagged that way so some mis-match
statuses will be ignored.
Students are never unfledged from this automatically, this has to be
done in the management console UI where they can also be flagged
manually.
Re-ordered the steps to match what is now happening.
Fix a refactoring mistake that was setting all former students to
students when they were updated.
thecoolestguy added a commit that referenced this pull request Oct 10, 2014
Flag Former Students in the sync process
@thecoolestguy thecoolestguy merged commit 72ba416 into ilios:master Oct 10, 2014
@jrjohnson jrjohnson deleted the edssync branch December 1, 2014 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identifying students once they have graduated as "graduates"
3 participants