Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

576 course filing removal bug #706

Merged
merged 5 commits into from
Oct 7, 2014

Conversation

thecoolestguy
Copy link
Member

fixes #576

@jrjohnson
Copy link
Member

@thecoolestguy are there any changes to this since it was tested in #576? Or can I go ahead and merge without further testing?

@saschaben
Copy link
Member

should be good to merge. @thecoolestguy made the PR after I confirmed the tests all passed without issue.

@saschaben
Copy link
Member

@jrjohnson can we get this reviewed/merged/pulled? I'd like to get this one out of the way so we can address the former students stuff, and then the filter bug. thx!

@jrjohnson
Copy link
Member

I thought we were waiting for another manual test pass since the migration script had been updated. If @thecoolestguy says its ready though, I will merge.

@saschaben
Copy link
Member

tested again. and passed. we're all good on the user side.

jrjohnson added a commit that referenced this pull request Oct 7, 2014
@jrjohnson jrjohnson merged commit 6e310fd into ilios:master Oct 7, 2014
@thecoolestguy thecoolestguy deleted the 576_course_filing_removal_bug branch May 24, 2016 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Filing" a course removes it from the calendar search/filter widget
3 participants