Stop deactivating new student accounts #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much searchign has lead to no reason why these accounts are being disabled uopon ingestion. The only thing we can come up with is that this process has never worked without manual DB intervention or the uploading of records via the learner group cohort manager.
jrjohnson
force-pushed
the
active-newstudents
branch
from
50480c7
to
0f51893
Compare
|
This test is failing because it is brittle on the show_more_less link bug and phantomJS will not consistently download probably because we require an old version. I think we should go ahead and merge. |
|
let's get code review taken care of so it can be merged --- this is going to be a blocker for the schools in the coming weeks so we will need to patch ucsf..... |
stopfstedt
added a commit
that referenced
this pull request
Aug 14, 2015
Stop deactivating new student accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason new student accounts are being deactivated on creation. This is not correct. (read bone headed bug I created).