Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Authorization #948

Merged
merged 258 commits into from
Aug 13, 2015
Merged

User Authorization #948

merged 258 commits into from
Aug 13, 2015

Conversation

stopfstedt
Copy link
Member

refs #887

@stopfstedt
added Aamc Method Voter.
a5cd155
@stopfstedt
added curriculum inventory report voter.
a071a84
@stopfstedt
removed user/report school comparison from voter.
921cdae
@stopfstedt
added curriculum inventory academic level voter.
31e2416
@stopfstedt
IN YOUR (INTER)FACE!
8377b2f
@stopfstedt
added curr inv export voter.
63dcf9b
@stopfstedt
added curr inventory institution voter.
96265cb
@stopfstedt
added curr inv sequence block voter.
1a8c63e
@stopfstedt
added curr inv sequence voter.
eb94db2
@stopfstedt
added Donaudampfschifffahrtgesellschaftskapitaenmuetze voter.
7b87871
@stopfstedt
Added alert type change voter.
a9d70e3
@stopfstedt
grant View privileges to all auth users, but edit/delete only to devs.
1256eff
@stopfstedt
injected entity manager into base voter. rewired services accordingly.
ffa9e04
@stopfstedt
meh. rolled back entity manager injection
bf0cb27
@stopfstedt
file name fix: *voter, not *controller.
5f96eb9
@stopfstedt
fine tuned grants-check in curr inv export voter.
ad52792
@stopfstedt
registered voters as services.
244c7fb
@stopfstedt
tuned permissions check in curriculum inventory voters. updated/added…
942249e 
… comments.
@stopfstedt
tuned perms check in curr inv academic lvl voter.
e2ec59f
@stopfstedt
added alert voter.
a35f3a2
@stopfstedt
tweaked alert voter perms check.
61c059e
@stopfstedt
added assessment option voter.
40d9a3f
@stopfstedt
programming against interfaces
f880040
@stopfstedt
added cohort voter.
75906b6
@stopfstedt
wired alert voter up to services registry.
2d16860
@stopfstedt
wired assessment option voter in services registry.
13edb05
@stopfstedt
import user interface.
e3784dc
@stopfstedt
program against entity manager interfaces, not handlers.
3bd032c
@stopfstedt
wired up cohort voter in service registry.
a290094
@stopfstedt
appeasing the codesniffler.
4488870
@stopfstedt
Copy link
Member Author

some notes:

  • the controller tests use dummy user two (user id = 2), who has the developer role and should be able to see and modify everything as applicable.
  • the heart of the authorization system is in the voters, see Ilios/AuthenticationBundle/Voters.

jrjohnson
jrjohnson reviewed Aug 12, 2015
View reviewed changes
src/Ilios/AuthenticationBundle/Resources/config/services.yml
@@ -24,3 +24,260 @@ services:
class: Ilios\AuthenticationBundle\Shibboleth\Authentication
scope: request
arguments: ["@request", "@ilioscore.authentication.manager"]
security.access.aamc_method_voter:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pulling these out into a separate voters.yml file to make services easier to work with.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on it.

@stopfstedt stopfstedt assigned stopfstedt and jrjohnson and unassigned stopfstedt Aug 13, 2015
@jrjohnson
Copy link
Member

Does that mean this is ready for review and possible merge?

@stopfstedt
Copy link
Member Author

yes, please review/merge. thanks!

jrjohnson added a commit that referenced this pull request Aug 13, 2015
@jrjohnson
Merge pull request #948 from stopfstedt/authorization
be36bd1 
User Authorization
@jrjohnson jrjohnson merged commit be36bd1 into ilios:master Aug 13, 2015
@stopfstedt stopfstedt deleted the authorization branch August 13, 2015 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrjohnson jrjohnson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stopfstedt @jrjohnson