import default data population #982
Conversation
|
still WIP as unit tests and MeSH fixtures are still missing. it works tho. |
| @@ -0,0 +1,34 @@ | |||
| LOCK TABLES `competency` WRITE; | |||
There was a problem hiding this comment.
I'm guessing all fo these .sql files were committed accidentally? Otherwise I don't know what they are for?
There was a problem hiding this comment.
good catch. they are left over from an earlier, aborted attempt to run queries against the db via doctrine.
removing them...
|
added tests, this is good to go (unless travis sez otherwise). willl deal with mesh another day... |
|
|
||
| // honor the given entity identifiers. | ||
| // @link http://www.ens.ro/2012/07/03/symfony2-doctrine-force-entity-id-on-persist/ | ||
| $metadata = $manager->getClassMetaData(get_class($entity)); |
There was a problem hiding this comment.
There is a force ID option in the entity managers:
https://github.com/ilios/ilios/blob/master/src/Ilios/CoreBundle/Entity/Manager/AamcPcrsManager.php#L57
It may be too much work to inject our custom managers, but maybe that is what the $manager is. I'm not sure.
I'm also worried that we're using a different pattern in these two places. I have no idea what the correct path might be so I'm good with this one, just a comment.
Last, I think you can call these two metadata lines a single time before the loop as opposed to on each iteration. There may be a slight performance bump in doing that, or maybe it will break everything.
|
Looks good; couple of comments which you can ignore. |
|
I think we should continue to provide the default set of schools (SOM, SOP, SOD, SON) but the departments is an open question. We don't really leverage them in any way currently, so it doesn't really offer much to other schools in way of example. |
…g loading process.
…est into base parent class.
…d annotations while at it.
|
:+1 |
import default data population
fixes #892