-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LDAP authentication option #998
Conversation
* Authenticate a user from shibboleth | ||
* | ||
* If the user is not yet logged in send a redirect Request | ||
* If the uesr is logged in, but no account exists send an error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo "uesr"
a12607b
to
130e9f6
Compare
We were not actually using this.
Better organization for authentication into services as well as making the service responsible for creating specific responses which can be consumed by the fronted or other clients.
Allows implementers to use ldap as an authentication store by attempting a bind against the ldap server. Add new ldap keys to travis parameters file
Since we have no sessions there is no point in having a logout
130e9f6
to
b49c3e7
Compare
@stopfstedt - this is ready to be reviewed again |
|
||
/** | ||
* Refresh the current token | ||
* Usefull when the time limt is approaching but the user is still active |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix typos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No fair, I actually spell checked this one. Stupid text edit.
protected $authManager; | ||
|
||
/** | ||
* @var Encoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be @var UserPasswordEncoderInterface
.
👍 |
Add LDAP authentication option
Cleaned up and refactored Form and Shibboleth authentication patterns.
Added Ldap authentication option fixes #979