Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDAP authentication option #998

Merged
merged 9 commits into from
Sep 2, 2015
Merged

Conversation

jrjohnson
Copy link
Member

Cleaned up and refactored Form and Shibboleth authentication patterns.

Added Ldap authentication option fixes #979

@jrjohnson jrjohnson changed the title Authentication Redux Add LDAP authentication option Sep 1, 2015
* Authenticate a user from shibboleth
*
* If the user is not yet logged in send a redirect Request
* If the uesr is logged in, but no account exists send an error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "uesr"

We were not actually using this.
Better organization for authentication into services as well as making
the service responsible for creating specific responses which can be
consumed by the fronted or other clients.
Allows implementers to use ldap as an authentication store by
attempting a bind against the ldap server.

Add new ldap keys to travis parameters file
Since we have no sessions there is no point in having a logout
@jrjohnson
Copy link
Member Author

@stopfstedt - this is ready to be reviewed again


/**
* Refresh the current token
* Usefull when the time limt is approaching but the user is still active
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix typos.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fair, I actually spell checked this one. Stupid text edit.

protected $authManager;

/**
* @var Encoder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be @var UserPasswordEncoderInterface.

@stopfstedt
Copy link
Member

👍

@stopfstedt stopfstedt assigned dartajax and unassigned stopfstedt Sep 2, 2015
dartajax added a commit that referenced this pull request Sep 2, 2015
Add LDAP authentication option
@dartajax dartajax merged commit d8283c7 into ilios:master Sep 2, 2015
@jrjohnson jrjohnson deleted the 979-ldapauth branch September 3, 2015 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow authentication via LDAP
3 participants