Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aard2 Slob alias bug: cherry-pick upstream bugfix #556

Closed
soshial opened this issue Apr 15, 2024 · 14 comments
Closed

Aard2 Slob alias bug: cherry-pick upstream bugfix #556

soshial opened this issue Apr 15, 2024 · 14 comments

Comments

@soshial
Copy link
Contributor

soshial commented Apr 15, 2024

Please, cherry-pick the latest bug-fix, that fixes a problem of alias not being able to point to several glosses.

@soshial soshial changed the title Aard2 slob: alias bug from upstream Aard2 slob upstream bug: alias (cherry-pick) Apr 15, 2024
@ilius
Copy link
Owner

ilius commented Apr 17, 2024

For some reason the ci test is failing for python 3.10.
But works for me with Python 3.10.12

tests $ pyenv local 3.10
tests $ python -m unittest slob_test.py 
....................
----------------------------------------------------------------------
Ran 20 tests in 3.279s

OK
tests $ python
Python 3.10.12 (main, Aug 21 2023, 15:17:32) [GCC 13.2.0] on linux

@soshial soshial changed the title Aard2 slob upstream bug: alias (cherry-pick) Aard2 Slob alias bug: cherry-pick upstream bugfix Apr 17, 2024
@soshial
Copy link
Contributor Author

soshial commented Apr 17, 2024

Thanks for cherry-picking the bugfix. Can test failure be because of some problems with PyICU on CI? ICU is always is a source of problems when I convert to Slob.

@ilius
Copy link
Owner

ilius commented Apr 17, 2024

It failed locally with python 3.10.14 and PyICU-2.12-cp310-cp310-linux_x86_64.whl
It works on https://github.com/itkach/slob/

@ilius
Copy link
Owner

ilius commented Apr 17, 2024

Yes! It works with pyicu-2.11.
Also works with pyicu-2.12 with python-3.10.13
So maybe it's a bug in pyicu-2.12 which only happens on Python 3.10.14.
So strange!

@soshial
Copy link
Contributor Author

soshial commented Apr 17, 2024

I noticed that your commits made in April have disappeared. Did you remove them on purpose or by mistake?

Screenshot 2024-04-17 at 19 15 41

@ilius
Copy link
Owner

ilius commented Apr 17, 2024

Oops!
I pushed them back again.

@ilius
Copy link
Owner

ilius commented Apr 17, 2024

Now it fails on 3.12 on ci!

@ilius
Copy link
Owner

ilius commented Apr 17, 2024

I'm just gonna use PyICU==2.11 for now!

@ilius
Copy link
Owner

ilius commented Apr 17, 2024

I still don't understand how the test passes for https://github.com/itkach/slob

@ilius
Copy link
Owner

ilius commented Apr 17, 2024

Okay so it sometimes passes and sometimes fails on either project!!

@ilius
Copy link
Owner

ilius commented Apr 17, 2024

I'm not even sure it has something to do with python version anymore!

@ilius
Copy link
Owner

ilius commented Apr 17, 2024

Got it!

itkach/slob#50

@ilius
Copy link
Owner

ilius commented Apr 17, 2024

This is why all projects should have test and CI / github action.

@ilius ilius closed this as completed Apr 17, 2024
@soshial
Copy link
Contributor Author

soshial commented Apr 17, 2024

Wow, that's pretty cool you fixed that test! It's nice to see improvement of pyglossary and Slob libraries with the help of community :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants