does not fire @select when using keyboard #9
Labels
bug
Something isn't working
Comments
|
Fixed in Demo: https://codesandbox.io/s/w6m23jv3o5 Thank you very much for finding bugs, this is very useful, but I feel ashamed that I have made so many bugs 😄 |
|
Do not be ashamed ... I really enjoyed your lib. Thanks for the correction. |
|
is it better to put the item as selected when the enter is fired and not keydown or keyup? |
|
Perhaps this is better, I do not see a serious reason to rewrite the code. |
iliyaZelenko
added a commit
that referenced
this issue
Sep 18, 2019
the arrowsDisableInstantSelection prop has true by default BREAKING CHANGE: previously there was the false vlue, which led to the immediate selection of a menu item. I decided that this was not the best practice. re #9
iliyaZelenko
pushed a commit
that referenced
this issue
Sep 18, 2019
# [3.0.0](v2.11.1...v3.0.0) (2019-09-18) ### Bug Fixes * **getitemvalue:** improve comparison to null and undefined ([a53dfe4](a53dfe4)), closes [#199](#199) ### Features * **build:** added rollup, postcss ([d901fd9](d901fd9)) * **classes:** iZ-select--with-value class if select has value ([c978a76](c978a76)) * **component:** different sizes ([1e498e5](1e498e5)) * **component:** improve the `inputStyles` logic and height style ([1aeb01d](1aeb01d)) * **plugin's options:** the text option to set custom no data text ([9698298](9698298)) * **props:** arrowsDisableInstantSelection prop ([59e9af4](59e9af4)), closes [#9](#9) * **props:** discard the loadingIndicator prop ([0c18790](0c18790)) * **sizes:** changed the idea about different sizes ([1abdf8d](1abdf8d)) ### BREAKING CHANGES * **props:** this prop no longer exists * **props:** previously there was the false vlue, which led to the immediate selection of a menu item. I decided that this was not the best practice. * **component:** the sizes are adjusted to fit the bootstrap styles perfectly, maybe they changed a little * **build:** new build system (styles separated)
rin4573281133639
added a commit
to rin4573281133639/iliyaZelenko9
that referenced
this issue
Feb 5, 2022
# [3.0.0](iliyaZelenko/vue-cool-select@v2.11.1...v3.0.0) (2019-09-18) ### Bug Fixes * **getitemvalue:** improve comparison to null and undefined ([a53dfe4](iliyaZelenko/vue-cool-select@a53dfe4)), closes [#199](iliyaZelenko/vue-cool-select#199) ### Features * **build:** added rollup, postcss ([d901fd9](iliyaZelenko/vue-cool-select@d901fd9)) * **classes:** iZ-select--with-value class if select has value ([c978a76](iliyaZelenko/vue-cool-select@c978a76)) * **component:** different sizes ([1e498e5](iliyaZelenko/vue-cool-select@1e498e5)) * **component:** improve the `inputStyles` logic and height style ([1aeb01d](iliyaZelenko/vue-cool-select@1aeb01d)) * **plugin's options:** the text option to set custom no data text ([9698298](iliyaZelenko/vue-cool-select@9698298)) * **props:** arrowsDisableInstantSelection prop ([59e9af4](iliyaZelenko/vue-cool-select@59e9af4)), closes [#9](iliyaZelenko/vue-cool-select#9) * **props:** discard the loadingIndicator prop ([0c18790](iliyaZelenko/vue-cool-select@0c18790)) * **sizes:** changed the idea about different sizes ([1abdf8d](iliyaZelenko/vue-cool-select@1abdf8d)) ### BREAKING CHANGES * **props:** this prop no longer exists * **props:** previously there was the false vlue, which led to the immediate selection of a menu item. I decided that this was not the best practice. * **component:** the sizes are adjusted to fit the bootstrap styles perfectly, maybe they changed a little * **build:** new build system (styles separated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
when you search for an item and use the down arrow and then enter it does not fire @select.
example: https://codesandbox.io/s/zwn46x1kpx
maybe it's the problem here
https://github.com/iliyaZelenko/vue-cool-select/blob/master/src/component.vue#L66
The text was updated successfully, but these errors were encountered: