New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serious issue: Please do *not* accept commits with extremely large files #605
Comments
See #555 |
I have to agree. |
Serious projects should take a long time to clone. Where else should we put the ios app? |
@hhirsch Submodule. |
Could someone rewrite history to remove those huge files? |
@progval I've tried, but it ends up freezing my CPU for way too long. Way too many commits to go through. |
I am going to rewrite the history very soon, replacing it with an initial commit. Removed folders: |
The repository has been rebased. Unfortunately, I can't seem to update the old, backup copy of master due to file size constraints... |
:/ |
@MiLk I don't like deleting content either, but the repo size really needs a limit. I can't even run |
Thanks for taking care of this issue! 😃 |
Next time: https://help.github.com/articles/remove-sensitive-data/ |
👍 |
@MiLk There were literally 90000 commits or whatever for filter-branch to go through. Which would have taken forever to complete... |
👍 How long did it take? |
|
I will try to cherry pick everything which has been made since the end of my rewritten branch. |
@illacceptanything/owners I would like to start a vote to replace the current master by https://github.com/illacceptanything/illacceptanything/commits/rewrite The vote will end in 12 hours. (2am UTC / 11am JST / 7pm PDT) Until the end of the vote, please don't merge anything. |
@MiLk I didn't see this issue before, so I merged a minor change a few minutes ago... (only readme was affected) - I won't merge anything else till the end of the vote 👍 I agree with the rewrite, seems fine. |
Sounds good to me On Sat, Apr 11, 2015 at 8:01 AM, hiiru notifications@github.com wrote:
|
Would a squash merge do it? I don't really care, honestly. |
I'll Accept Anything ™️ On Sat, Apr 11, 2015 at 9:35 AM, James Lu notifications@github.com
|
👍 Go ahead and do it! |
Lol, totally agree, toke forever to clone. First time contributing to open source project don't know how it works, cloned like 15 times, went way over my internet bandwidth. |
I'll check right now which directory/file is the worst offender. Here are all files greater than 1M:
|
Lol just had a funny idea: change this repo to |
@initbar no :( |
suggestion: can we devote For example, we can have:
Which looks better than:
This way, (1) when someone needs to use |
+1 |
Most of the stuff in |
but you deleted the most random of them :( |
I could do a massive organization pretty easily: should I do the cleanup and make a pull request (I promise not to delete anything)? |
Done. @initbar Please open a PR. |
I don't really think more sorting is needed atm... Either way, don't prefix the directory names with a |
It's still sooo big... |
This is a serious issue. I have an actual concern I'd like to address.
I'm having a lot of fun with this repo! When I cloned it onto my own machine, though, it took about 15 minutes to clone. Looking through the repo, I noticed that about 1.5 GB of content was coming from just two top-level directories. One looked like a 1GB iOS app that included several 100+MB images, and the second looks like a clone of a linux distro.
Under the stated rule of "Don't be a d---," I request that you not accept pull requests with extremely large files. Waiting 15 minutes to clone my project really wasn't that bad, and I have more than 1GB to spare, so I'm not upset about the aforementioned files. However, if many people commit 1GB+ files, or someone tries to commit something on the order of 10-100GB+, it could make cloning the project almost impossible, killing all of the fun.
The text was updated successfully, but these errors were encountered: