some fart refactoring and add composer to ass module #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you actually need PHP 5.4, a framework, and a file system mock to do that in PHP? |
|
@progval , yes and it's not completed list of dependencies. |
|
@progval I think in better case all possible dependencies should be included for this project. |
|
We're planning on writing our own OS for that |
|
How big are these commits? LGTM otherwise. |
They are ok. What's the issue?
“LGTM”? |
|
Looks Good To Me. |
jlu5
pushed a commit
that referenced
this pull request
Sep 5, 2015
some fart refactoring and add composer to ass module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.