Allow specifying custom error types for TryFrom implementations #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib.rs is getting huge and unwieldy. This is a pure code move.
qwandor
approved these changes
Aug 4, 2023
illicitonion
force-pushed
the
custom-error-types
branch
from
4be91c5
to
b0fe7f9
Compare
illicitonion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour remains the same, but error types can be customised.
This is a breaking change, as it adds a new associated type to
TryFromPrimitive- while we don't expect this to break anyone's code, we'll bump to 0.7.0 to be safe.