Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is failing #539

Closed
inducer opened this issue Oct 29, 2021 · 2 comments
Closed

CI is failing #539

inducer opened this issue Oct 29, 2021 · 2 comments

Comments

@inducer
Copy link
Contributor

inducer commented Oct 29, 2021

E.g.

2021-10-28T22:15:50.4341011Z _ test_slipwall_flux[<PyOpenCLArrayContext for <pyopencl.Device 'pthread-Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz' on 'Portable Computing Language'>>-1-2] _
2021-10-28T22:15:50.4341942Z Traceback (most recent call last):
2021-10-28T22:15:50.4342588Z   File "/home/runner/work/grudge/grudge/mirgecom/test/test_bc.py", line 170, in test_slipwall_flux
2021-10-28T22:15:50.4343495Z     message = (f"EOC:\n{eoc}")
2021-10-28T22:15:50.4344633Z   File "/home/runner/work/grudge/grudge/mirgecom/.miniforge3/envs/testing/lib/python3.8/site-packages/pytools/convergence.py", line 85, in __str__
2021-10-28T22:15:50.4345962Z     return self.pretty_print()
2021-10-28T22:15:50.4347281Z   File "/home/runner/work/grudge/grudge/mirgecom/.miniforge3/envs/testing/lib/python3.8/site-packages/pytools/convergence.py", line 67, in pretty_print
2021-10-28T22:15:50.4348435Z     gm_eoc = self.estimate_order_of_convergence(gliding_mean)
2021-10-28T22:15:50.4351042Z   File "/home/runner/work/grudge/grudge/mirgecom/.miniforge3/envs/testing/lib/python3.8/site-packages/pytools/convergence.py", line 36, in estimate_order_of_convergence
2021-10-28T22:15:50.4352318Z     errors += (1 if emax == 0 else emax) * np.finfo(errors.dtype).eps
2021-10-28T22:15:50.4354070Z   File "/home/runner/work/grudge/grudge/mirgecom/.miniforge3/envs/testing/lib/python3.8/site-packages/numpy/core/getlimits.py", line 398, in __new__
2021-10-28T22:15:50.4355457Z     raise ValueError("data type %r not inexact" % (dtype))
2021-10-28T22:15:50.4356392Z ValueError: data type <class 'numpy.object_'> not inexact

This is making the downstream CIs of many upstream packages unhappy as well.

inducer added a commit that referenced this issue Oct 29, 2021
@MTCam
Copy link
Member

MTCam commented Oct 29, 2021

We are painfully aware of this. When inducer/grudge#170 merged in grudge, it basically broke all of MIRGECom. Working installs are impossible at this point unless you pick up the changes from #518.

We've been ganging up working on this since inducer/grudge/#170 merged.

@inducer
Copy link
Contributor Author

inducer commented Oct 29, 2021

Thanks @MTCam for working on this. All better now that #518 is in.

@inducer inducer closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants