Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict flake8 version #803

Merged
merged 1 commit into from Nov 29, 2022
Merged

Restrict flake8 version #803

merged 1 commit into from Nov 29, 2022

Conversation

matthiasdiener
Copy link
Member

@matthiasdiener matthiasdiener commented Nov 29, 2022 •
edited

Due to zheller/flake8-quotes#110

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@majosm majosm self-requested a review November 29, 2022 16:23
@matthiasdiener matthiasdiener marked this pull request as ready for review November 29, 2022 16:24
@matthiasdiener matthiasdiener enabled auto-merge (squash) November 29, 2022 16:24
@matthiasdiener matthiasdiener self-assigned this Nov 29, 2022
@matthiasdiener matthiasdiener merged commit 3b3693d into main Nov 29, 2022
@matthiasdiener matthiasdiener deleted the flake8-ci branch November 29, 2022 17:33
matthiasdiener added a commit that referenced this pull request Dec 20, 2022
@matthiasdiener
Revert "Restrict flake8 version (#803)"
7408db3 
This reverts commit 3b3693d.

flake8-quotes v3.3.2 is compatible with flake8 v6.
@matthiasdiener matthiasdiener mentioned this pull request Dec 20, 2022
Merged
8 tasks
matthiasdiener added a commit that referenced this pull request Dec 21, 2022
@matthiasdiener
Revert "Restrict flake8 version (#803)" (#812)
17c327f 
This reverts commit 3b3693d.

flake8-quotes v3.3.2 is compatible with flake8 v6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majosm majosm majosm approved these changes

Assignees

@matthiasdiener matthiasdiener

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthiasdiener @majosm