Allow course staff to add students to queue #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genevievehelsel
requested changes
Apr 10, 2018
components/NewQuestion.js
Outdated
| placeholder="Enter a Net ID (optional)" | ||
| value={this.state.netid} | ||
| onChange={this.handleInputChange} | ||
| valid={isValid(this.state.fieldErrors.name)} |
There was a problem hiding this comment.
should this be this.state.fieldErrors.netid?
genevievehelsel
requested changes
Apr 10, 2018
There was a problem hiding this comment.
One thing (not too big of a deal though), maybe if a user is course staff, change the wording to "Enter your name" to "Enter the student's name".
One thing testing locally, due to the hiding the new question panel for active course staff, if a user is on duty, they can't add someone to the queue as the panel isn't there. There will either need to be a button to reshow that panel, that feature being removed, or some other thing.
genevievehelsel
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65