Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker/TimePicker miss inputClass #269

Closed
jcschmidig opened this issue Jun 10, 2021 · 3 comments · Fixed by #284
Closed

DatePicker/TimePicker miss inputClass #269

jcschmidig opened this issue Jun 10, 2021 · 3 comments · Fixed by #284

Comments

@jcschmidig
Copy link

It would be nice to have the inputClass also for Date/TimePicker. This is a very convenient way to instruct and style the component.
@illright
Copy link
Owner

What DOM element in particular would you like to style with inputClass? The thing is, DatePicker doesn't even have an <input> internally, it only borrows it from TextInput. Do you want to style the <input> element of these TextInputs?

@jcschmidig
Copy link
Author

As the name says, it's the input class of the respective TextField element. It's not only for styling but also for processing within the form where it's included. Additionally it would be nice to propagate the $$restprops to the TextField too.
Great job by the way. I really like your work.

@illright illright reopened this Aug 11, 2021
@illright
Copy link
Owner

Why did you close this issue? It does seem like a nice addition

aabounegm added a commit that referenced this issue Aug 14, 2021
@aabounegm
Add the inputClass prop to TimePicker & DatePicker
5f31fd3 
So that they can be passed down to the `TextField` inside.
Resolves #269
@aabounegm aabounegm mentioned this issue Aug 14, 2021
Merged
aabounegm added a commit that referenced this issue Aug 14, 2021
@aabounegm
Add the inputClass prop to TimePicker & DatePicker
9c42468 
So that they can be passed down to the `TextField` inside.
Resolves #269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the inputClass prop to TimePicker & DatePicker illright/attractions
2 participants
@jcschmidig @illright